Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruhrohrotaryio for non-sequential pin rotaryio use on rp2040 et al #189

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Add ruhrohrotaryio for non-sequential pin rotaryio use on rp2040 et al #189

merged 1 commit into from
Oct 16, 2023

Conversation

todbot
Copy link
Contributor

@todbot todbot commented Oct 16, 2023

The rotaryio on at least RP2040 boards requires sequential GPIO pins which is confusing on, say, the QTPy RP2040 where pins seemingly next to each other like TX & SCL are not actually GPIO sequential. This little "fake rotaryio" driver acts like rotaryio but lets you any two pins.

FoamyGuy
FoamyGuy approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

Neat idea to "fall back" on keypad in situations when rotaryio cannot work with the pins.

@FoamyGuy FoamyGuy merged commit ec62ab1 into adafruit:main Oct 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@todbot @FoamyGuy